Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curseofwar,curseofwar-sdl: init at 1.2.0 #64304

Merged
merged 1 commit into from Jul 5, 2019
Merged

curseofwar,curseofwar-sdl: init at 1.2.0 #64304

merged 1 commit into from Jul 5, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 4, 2019

Motivation for this change

Just a game

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Not sure if it will build on darwin. Could some trusted user run the build?

jonringer
jonringer approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64304 passes on NixOS
diff LGTM
both binaries/games work

[5 built, 1 copied (0.2 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64304
2 package were build:
curseofwar curseofwar-sdl

[nix-shell:/home/jon/.cache/nix-review/pr-64304]$ nix path-info -Sh ./results/curseofwar/
/nix/store/g8rhbfz7jc3s517nvlk4vlp088i85pv6-curseofwar-1.2.0      30.2M

[nix-shell:/home/jon/.cache/nix-review/pr-64304]$ nix path-info -Sh ./results/curseofwar-sdl/
/nix/store/y31knd0zbkjign97cqvz7wwsqmckp1aw-curseofwar-1.2.0      79.3M

@teto
Copy link
Member

teto commented Jul 5, 2019

thanks for the addition and the review. Looks interesting

@teto teto merged commit 1c67718 into NixOS:master Jul 5, 2019
@fgaz fgaz deleted the curseofwar/init branch May 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @teto @jonringer