Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimalloc: init at 1.0.8 #64276

Merged
merged 1 commit into from Sep 23, 2019
Merged

mimalloc: init at 1.0.8 #64276

merged 1 commit into from Sep 23, 2019

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Jul 4, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS

@thoughtpolice thoughtpolice self-assigned this Jul 4, 2019
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build mimalloc

jonringer
jonringer reviewed Jul 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing in the dev output

[nix-shell:/home/jon/.cache/nix-review/pr-64276]$ tree ./results/*
./results/mimalloc
└── lib
    ├── libmimalloc.a
    ├── libmimalloc.so
    └── mimalloc.o

1 directory, 3 files

@thoughtpolice
Copy link
Member Author

I don't know what nix-review is doing I'm afraid, but the .dev output does indeed work:

[a@link:/etc/nixos/nixpkgs]$ nix-build -A mimalloc.dev
/nix/store/cakp59n2if4c86a19dmxqi0j67xzjj7c-mimalloc-1.0pre104_1125271-dev

[a@link:/etc/nixos/nixpkgs]$ find result-dev/
result-dev/
result-dev/share
result-dev/share/cmake
result-dev/share/cmake/mimalloc-config.cmake
result-dev/share/cmake/mimalloc-config-version.cmake
result-dev/share/cmake/mimalloc.cmake
result-dev/share/cmake/mimalloc-release.cmake
result-dev/include
result-dev/include/mimalloc.h
result-dev/nix-support
result-dev/nix-support/propagated-build-inputs

@thoughtpolice
Copy link
Member Author

(And also I think the cmake directory is wrong too for cmake to find the .cmake files, but I mainly wanted to get this checked on x86_64-darwin, first)

@jonringer
Copy link
Contributor

ah, different result directory, :) okay

@thoughtpolice
mimalloc: init at 1.0.8
a098b8e 
Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build mimalloc

@thoughtpolice thoughtpolice changed the title mimalloc: init at 1.0pre104_1125271 mimalloc: init at 1.0.8 Sep 23, 2019
@thoughtpolice
Copy link
Member Author

I unfortunately couldn't get the .cmake files to properly install right, so I think that we'll probably need some patches upstream. In the mean time, this version does expose the headers and libraries in the usual way, and also enables the secure memory allocator by default (at a marginal slowdown, which can optionally be turned off)

@thoughtpolice thoughtpolice merged commit 544b85a into NixOS:master Sep 23, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/add-mimalloc branch September 23, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @jonringer