Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.switchboard-plug-pantheon-shell: Fix setting lightdm background #64273

Merged
merged 1 commit into from Jul 17, 2019
Merged

pantheon.switchboard-plug-pantheon-shell: Fix setting lightdm background #64273

merged 1 commit into from Jul 17, 2019

Conversation

worldofpeace
Copy link
Contributor

backports elementary/switchboard-plug-pantheon-shell@e4f86df

Motivation for this change

Setting the lightdm background with the lightdm-gtk-greeter was broken.
This patch should have that working as expected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

@davidak Could you test this patch on stable?

@davidak
Copy link
Member

davidak commented Jul 10, 2019

@worldofpeace sure. can you tell me the steps for testing? should the desktop background for a user also be used in the greeter?

@worldofpeace
Copy link
Contributor Author

@worldofpeace sure. can you tell me the steps for testing? should the desktop background for a user also be used in the greeter?

  1. open switchboard and select a desktop background in the Desktop plug.
  2. Log Out or Lock the session. The wallpaper for the greeter should be the same
    as the one you selected for the session.

@worldofpeace worldofpeace merged commit 24c731b into NixOS:master Jul 17, 2019
@worldofpeace worldofpeace deleted the switchboard-plug-pantheon-shell/fix-lightdm branch July 17, 2019 15:03
@davidak
Copy link
Member

davidak commented Aug 2, 2019

Oh, i thought i had to backport the commit also, but it's already there. Then it's easy to test.

I can confirm this works also on stable. Thanks!

  • system: "x86_64-linux"
  • host os: Linux 4.19.63, NixOS, 19.03.173221.9ca57dc9171 (Koi)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.2.2
  • channels(davidak): ""
  • channels(root): "nixos-19.03.173221.9ca57dc9171, nixos-hardware, nixos-unstable-19.09pre186857.239fffc90d7"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

@worldofpeace
Copy link
Contributor Author

Thanks @davidak 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @davidak