Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.praw: 6.0.0 -> 6.3.1 #64277

Merged
merged 2 commits into from Jul 4, 2019
Merged

pythonPackages.praw: 6.0.0 -> 6.3.1 #64277

merged 2 commits into from Jul 4, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 4, 2019 •
edited

Motivation for this change

resolves #64086

fixes a broken build

also, updates a package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/fjwyzg93iwccjnqddg82hd7b8ncy0l1s-python3.7-praw-6.3.1 107.8M

@jonringer jonringer requested a review from FRidh as a code owner July 4, 2019 02:53
@teto
Copy link
Member

teto commented Jul 4, 2019

@GrahamcOfBorg build python3Packages.praw python27Packages.pyarrow python37Packages.image-match csvs-to-sqlite mpfshell

@teto
Copy link
Member

teto commented Jul 4, 2019 •
edited

seems like we can ignore the pyarrow error ? already present https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.python27Packages.pyarrow.x86_64-linux ?

@jonringer
Copy link
Contributor Author

I think so, those packages build fine on this branch

[06:07:01] jon@jon-desktop /home/jon/projects/nixpkgs (update-praw)
$ nix-build default.nix -A pythonPackages.pyarrow
/nix/store/cfszq8jl26zfwq8vz72s7m7qms020s7c-python2.7-pyarrow-0.13.0
[06:07:13] jon@jon-desktop /home/jon/projects/nixpkgs (update-praw)
$ nix-build default.nix -A python3Packages.pyarrow
/nix/store/xbrinh75ch73b36cdjyfz2771bbfl6qw-python3.7-pyarrow-0.13.0

@jonringer
Copy link
Contributor Author

nix-review pr 64277 fails on 6 packages, but all 6 are broken on master, so I don't think it's a regression

[142 built (6 failed), 483 copied (2507.3 MiB), 640.3 MiB DL]
error: build of '/nix/store/qc4p4ciq8dn1ipcfhy14x9m5siqbpgvz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64277
6 package failed to build:
appdaemon python27Packages.imbalanced-learn python27Packages.sumo python37Packages.imbalanced-learn python37Packages.sopel python37Packages.sumo

141 package were build:

@teto teto merged commit e6b6815 into NixOS:master Jul 4, 2019
@teto
Copy link
Member

teto commented Jul 4, 2019 •
edited

thanks. Next time I want a package updated, remind me to irritate you, people say I am really good at it ;)

@jonringer
Copy link
Contributor Author

@teto 4 of those will be fixed by #64303

@jonringer jonringer mentioned this pull request Jul 4, 2019
Merged
10 tasks
@jonringer jonringer deleted the update-praw branch July 9, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.praw fails to build on nixos-unstable
2 participants
@jonringer @teto