New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sauce-connect: 4.5.1 -> 4.5.4 #64261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind of nit picks?
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you can shorten this to just using system :)
|
||
src = fetchurl ( | ||
src = with stdenv.hostPlatform; fetchurl ( | ||
assertOneOf "hostPlatform" stdenv.hostPlatform.system [ "x86_64-linux" "i686-linux" "x86_64-darwin" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertOneOf "hostPlatform" stdenv.hostPlatform.system [ "x86_64-linux" "i686-linux" "x86_64-darwin" ] | |
assertOneOf "hostPlatform" system [ "x86_64-linux" "i686-linux" "x86_64-darwin" ] |
if stdenv.hostPlatform.system == "x86_64-linux" then { | ||
url = "https://saucelabs.com/downloads/sc-${version}-linux.tar.gz"; | ||
sha256 = "0lpfvlax7k8r65bh01i3kzrlmx0vnm9vhhir8k1gp2f4rv6z4lyx"; | ||
sha256 = "1w8fw47q4bzpk5jfagmc0cbp69jdd6jcv2xl1gx91cbp7xd8mcbf"; | ||
} else if stdenv.hostPlatform.system == "i686-linux" then { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if stdenv.hostPlatform.system == "i686-linux" then { | |
} else if system == "i686-linux" then { |
(triage):
|
I marked this as stale due to inactivity. → More info |
Motivation for this change
Update the version of sauce-connect needed for websocket support
Things done
Update and tested on nixos. Used prefetch to get hash for other platforms.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)