Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kallisto: 0.43.1 -> 0.46.0 #64289

Merged
merged 1 commit into from Sep 1, 2019
Merged

kallisto: 0.43.1 -> 0.46.0 #64289

merged 1 commit into from Sep 1, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 5, 2019

The build fails for me locally.

builder for '/nix/store/67w9r2sfyy0pr8gvys0nxwmlp3bfs93d-kallisto-0.46.0.drv' failed with exit code 2; last 10 log lines:
  Scanning dependencies of target kallisto
  make[2]: *** No rule to make target '../src/../ext/htslib/libhts.a', needed by 'src/kallisto'.  Stop.
  make[2]: *** Waiting for unfinished jobs....
  [ 89%] Building CXX object src/CMakeFiles/kallisto.dir/main.cpp.o
  make[1]: *** [CMakeFiles/Makefile2:130: src/CMakeFiles/kallisto.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....
  [ 93%] No install step for 'htslib'
  [ 96%] Completed 'htslib'
  [ 96%] Built target htslib
  make: *** [Makefile:130: all] Error 2

@GrahamcOfBorg build

@tadeokondrak tadeokondrak force-pushed the kallisto/update/0.46.0 branch 2 times, most recently from e4fee47 to da9b029 Compare July 5, 2019 23:42
@tadeokondrak
Copy link
Member Author

It seems to fail building in parallel sometimes, but builds parallel by default without Nix giving it the options.

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

@tadeokondrak could you please include the comment as per suggestion above?

@worldofpeace worldofpeace merged commit 732c0a0 into NixOS:master Sep 1, 2019
@worldofpeace
Copy link
Contributor

Thanks @tadeokondrak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadeokondrak @mmahut @worldofpeace