Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wafHook: Refactored wafHook to use callPackage #64250

Merged
merged 2 commits into from Jul 3, 2019
Merged

wafHook: Refactored wafHook to use callPackage #64250

merged 2 commits into from Jul 3, 2019

Conversation

xbreak
Copy link
Contributor

@xbreak xbreak commented Jul 3, 2019

Motivation for this change

This change is done to enable custom wafHooks with custom waf via the override
system. It should be a no-op.

Other setup hooks are located in pkgs/build-support/setup-hooks/. For now I put wafHook in the parent directory of its current location. If it's more suitable I can move it to pkgs/build-support.

@veprbl: Would you mind taking a look? Is it what you had in mind from this PR? Thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

xbreak and others added 2 commits June 27, 2019 12:15
@xbreak
wafHook: Refactored wafHook to use callPackage
bc0d5d5 
This is to enable custom wafHook with custom waf via the override
system.
@veprbl
!fixup
8c4ed06 
fix indentation
@veprbl
Copy link
Member

veprbl commented Jul 3, 2019

Yes, this is what I had in mind.

@veprbl veprbl merged commit 98d9a74 into NixOS:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xbreak @veprbl