Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonnet: ship new jsonnetfmt binary #64249

Merged
merged 1 commit into from Jul 3, 2019
Merged

jsonnet: ship new jsonnetfmt binary #64249

merged 1 commit into from Jul 3, 2019

Conversation

nshalman
Copy link
Member

@nshalman nshalman commented Jul 3, 2019 •
edited

Motivation for this change

Per https://github.com/google/jsonnet/releases/tag/v0.13.0 jsonnet fmt functionality was moved to a separate jsonnetfmt binary

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from benley and copumpkin July 3, 2019 13:58
@alyssais
Copy link
Member

alyssais commented Jul 3, 2019

@GrahamcOfBorg build jsonnet

@alyssais alyssais merged commit 7bd65a1 into NixOS:master Jul 3, 2019
@nshalman nshalman deleted the jsonnetfmt branch July 3, 2019 15:24
@nshalman
Copy link
Member Author

nshalman commented Jul 3, 2019

Thanks, @alyssais!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley Awaiting requested review from benley

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nshalman @alyssais