Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php upgrades #64326

Merged
merged 2 commits into from Jul 5, 2019
Merged

Php upgrades #64326

merged 2 commits into from Jul 5, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin July 5, 2019 07:41
@aanderse
Copy link
Member

aanderse commented Jul 5, 2019

Thanks @etu! Feel like back porting 7.2.20 because of #64183?

@aanderse aanderse merged commit 2720a1c into NixOS:master Jul 5, 2019
@aanderse aanderse mentioned this pull request Jul 6, 2019
Merged
10 tasks
@etu etu deleted the php-upgrades branch July 7, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @aanderse