Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elisa: 0.3.0 -> 0.4.2 #64327

Merged
merged 1 commit into from Jul 22, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Turns out some people don't have sound. As nothing else depends on elisa and having a media player without sounds is rather pointless, we should backport this.

Fixes #50726

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit a607a93 into NixOS:release-19.03 Jul 22, 2019
@peterhoeg peterhoeg deleted the u/elisa_stable branch July 22, 2019 07:28
@peterhoeg peterhoeg restored the u/elisa_stable branch July 22, 2019 10:47
@peterhoeg peterhoeg deleted the u/elisa_stable branch February 13, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant