New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keybase{,-gui}: 3.0.0 -> 4.1.0 #64375
keybase{,-gui}: 3.0.0 -> 4.1.0 #64375
Conversation
KBFS still isn't up to date (#64248) so I don't think a backport would be appropriate yet. |
Is it up-to-date on master? |
No it isn't, see this comment at #50999 (comment) and it was also mentioned in #64248 (comment)
|
Does that mean that #64275 was merged prematurely? |
I apologize, wasn't aware of this package. Future facing, #64377 imports the keybase package as part of kbfs, which should fix the issue of nix-review not picking it up. Thank you @worldofpeace for your attention to detail :) |
You're welcome. And I think because |
Ok this should be ready for someone to test it on stable. |
@worldofpeace I'm actually running unstable, I won't be able to test beyond simply building it. @Ma27 maybe? |
I'm on stable (NixOS 19.03). Can you give instructions on how to go about to test this? As a service is involved, I guess I'd have to install the to-be-tested version system-wide rather than simply run it with |
Precisely! I would point my nixpkgs to this specific PR and rebuild your system with Keybase and kbfs enabled. |
I've tested as follows: preparation
That didn't succeed. output (click to expand)
So I did sudo nixos-rebuild boot -p test -I nixpkgs=~/dev/nixos/nixpkgs/ and then rebooted into the resulting profile. tests done(after rebooting into the
👍 |
Sounds sufficiently tested, merging. |
Motivation for this change
Fix #64248 for stable branch by back-porting #60872, #62220 & #64275
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)