Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero-gui: only exclude darwin in meta.platforms #64305

Merged
merged 2 commits into from Aug 9, 2019
Merged

monero-gui: only exclude darwin in meta.platforms #64305

merged 2 commits into from Aug 9, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 4, 2019

Motivation for this change

The platforms have been restricted to x86_64-linux in the past because of failures for darwin and aarch64. However, I have just tried, aarch64 as well as i686 build now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (monero-gui)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

unfortunately qtwebengine is broken on darwin, so it's still accurate to exclude it :(

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 4, 2019

@jonringer ah, that's why. Is there an issue tracking this?

@jonringer
Copy link
Contributor

@rnhmjoj I have a 2012 Macbook Pro laying around and i tried doing the build, that's the package that it broke on. I'm personally not commited enough to darwin to try and fix it myself.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 6, 2019

I have just found out some of the patches weren't needed anymore (translations are finally embedded in the binary).

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 20, 2019

ping

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 26, 2019

Could this be merged?

@rnhmjoj rnhmjoj mentioned this pull request Aug 7, 2019
Merged
@mmahut
Copy link
Member

mmahut commented Aug 7, 2019

@GrahamcOfBorg build monero-gui

@mmahut mmahut merged commit f964c14 into NixOS:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @jonringer @mmahut @LnL7