Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"comb" should not be accepted as a name in ClockDomain(), DomainRenamer(), etc #125

Closed
whitequark opened this issue Jul 3, 2019 · 2 comments
Labels
Milestone

Comments

@whitequark
Copy link
Contributor

See #116 for motivation.

@whitequark whitequark added the bug label Jul 3, 2019
@whitequark whitequark added this to the 0.1 milestone Jul 3, 2019
@sbourdeauducq
Copy link
Member

Why not just use None instead in memory read ports?

@whitequark
Copy link
Contributor Author

@sbourdeauducq But that would still be a problem. Consider this code:

m = Module()
m.d.comb += a.eq(1)
m2 = DomainRenamer({"comb":"sync"})(m)

It wouldn't work the same as:

m2 = Module()
m2.d.sync += a.eq(1)

In fact this use of DomainRenamer is currently a no-op.

So regardless of the decision for #116, something needs to be fixed there, one way or another. (You could argue that this use of DomainRenamer should be valid--although I find it unconvincing--and then it would need to be fixed to accept such code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants