Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ksm: add option sleep #64355

Merged
merged 1 commit into from Jul 6, 2019
Merged

nixos/ksm: add option sleep #64355

merged 1 commit into from Jul 6, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 5, 2019

Motivation for this change

Add option sleep to allow change interval before next scan.
This option is needed to optimize the netdata service - https://docs.netdata.cloud/database/#ksm

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 2143f6f into NixOS:master Jul 6, 2019
@Izorkin Izorkin deleted the hardwareKSM branch July 6, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants