Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soundtouch: CVE-2018-1000223 CVE-2018-14044 CVE-2018-14045 #64354

Closed
wants to merge 2 commits into from
Closed

soundtouch: CVE-2018-1000223 CVE-2018-14044 CVE-2018-14045 #64354

wants to merge 2 commits into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 5, 2019

Motivation for this change

Fixes #64187.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 2.1.2 release should have all these fixes?

It would be ideal if we could just upgrade it.

@worldofpeace
Copy link
Contributor

If you do manage the update be sure to switch to using the proper pname instead of pName.

@mmahut mmahut mentioned this pull request Jul 7, 2019
Merged
10 tasks
@mmahut
Copy link
Member Author

mmahut commented Jul 7, 2019

Indeed, it makes sense to upgrade.

@mmahut mmahut closed this Jul 7, 2019
@mmahut mmahut deleted the soundtouch branch July 7, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 71: soundtouch-2.0.0: 3 advisories
2 participants
@mmahut @worldofpeace