gimp-with-plugins: Fix build errors with exiv2-0.27.1 #64353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build gimp-with-plugins |
worldofpeace
reviewed
Jul 6, 2019
| @@ -20,6 +20,10 @@ stdenv.mkDerivation rec { | |||
| gtk2 gtkimageview bzip2 zlib | |||
| libjpeg libtiff cfitsio exiv2 lcms2 lensfun | |||
| ] ++ stdenv.lib.optional withGimpPlugin gimp; | |||
| patches = [ | |||
There was a problem hiding this comment.
Can you add a comment that these are needed for exiv2 0.27.1?
Would it also be okay to combine these patches?
worldofpeace
reviewed
Jul 6, 2019
| #include <libgimp/gimpui.h> | ||
|
|
||
| +#include <exiv2/error.hpp> | ||
| #include <exiv2/image.hpp> |
There was a problem hiding this comment.
Upstream discourages from using individual header files since it breaks build, so you should just use
#include <exiv2/exiv2.hpp>
worldofpeace
reviewed
Jul 6, 2019
| #include "ufraw.h" | ||
|
|
||
| #ifdef HAVE_EXIV2 | ||
| +#include <exiv2/error.hpp> |
There was a problem hiding this comment.
10 tasks
neilmayhew
force-pushed
the
fix/gimp-plugins
branch
from
361fe79
to
57d8a94
Compare
|
Although I've updated this in response to your review comments, I expect you'll want to use #64607 instead. If so, I'll close this. |
|
That is true @neilmayhew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)