Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline-go: 1.12.1 -> 1.13.0 #64278

Merged
merged 1 commit into from Jul 5, 2019
Merged

powerline-go: 1.12.1 -> 1.13.0 #64278

merged 1 commit into from Jul 5, 2019

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Jul 4, 2019 •
edited

Motivation for this change

New version released by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor

xrelkd commented Jul 4, 2019

@GrahamcOfBorg build powerline-go

@xrelkd
Copy link
Contributor

xrelkd commented Jul 4, 2019

LGTM!
I also tested powerline-go locally on NixOS.
@marsam Could you merge this PR? Thank you very much!

marsam
marsam reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like upstream uses go modules, would you mind updating the expression to use buildGoModule?

@sifmelcara
Copy link
Member Author

Thanks for the suggestion! PR updated and tested again.
(and thanks @xrelkd for reviewing my pending PRs!)

@ofborg ofborg bot requested a review from kalbasit July 5, 2019 00:44
@marsam marsam merged commit 2e7402e into NixOS:master Jul 5, 2019
@marsam
Copy link
Contributor

marsam commented Jul 5, 2019 •
edited

Tested locally on NixOS and darwin.
Thanks @sifmelcara, and @xrelkd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sifmelcara @xrelkd @marsam