New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring libtimidity support back #7636
Comments
It is restored in emscripten PR: https://github.com/OpenTTD/OpenTTD/pull/7510/commits |
Perfect I didn’t see it! Hmm so my rebase should work. Weird. Closing the issue. |
Ah I see it is in a PR that hasn’t been merged yet. Ok that explains it then. I will wait for the PR to be merged. |
i'm not quite sure how you come to the conclusion that someone else should do this for you, instead of you just reverting the commit that removed it? |
I am calling for help here, because tried to revert it myself already, but so much has changed since it was first removed (especially in the configure script or config.libs or whatever it was called) that nothing compiled anymore after I tried to fix the conflicts. Configure scripts are a constant pain when rebasing/reverting etc. because everything touches them. |
Cherry-picking those commits from my PR should apply cleanly on master. |
Thanks, that is exactly what I was looking for :) |
Why was this closed? PR #7510 hasn’t been merged yet. |
This is a reminder to bring libtimidity support back, to enable me to more easily merge the code of my Switch port into this main repo. The Switch port relies on libtimidity for music.
Not having libtimidity causes a plethora of merge errors during my tries to rebase.
See discussion here #7333, where it was concluded that a port is needed that uses libtimidity to warrant bringing it back. Well thenSwitch port uses it and I am trying to upstream it so there’s that.
And the original commit that removed libtimidity here. #7326. A simple revert doesn’t seem to work anymore:
The text was updated successfully, but these errors were encountered: