Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.seekpath: mark as broken #64279

Closed
wants to merge 1 commit into from
Closed

pythonPackages.seekpath: mark as broken #64279

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

it's breaking a few other packages

Long log 
builder for '/nix/store/ha7m938bngggxm9n0k0dgczk2j454l59-python2.7-seekpath-1.8.4.drv' failed with exit code 1; last 10 log lines:
    File "/build/seekpath-1.8.4/seekpath/test_paths_hpkot.py", line 366, in base_test
      self.assertEqual(res['bravais_lattice_extended'], ext_bravais)
  AssertionError: 'oI3' != 'oI2'

  ----------------------------------------------------------------------
  Ran 69 tests in 1.138s

  FAILED (failures=1, skipped=2)
  Test failed: <unittest.runner.TextTestResult run=69 errors=0 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=69 errors=0 failures=1>
builder for '/nix/store/ihi4s44w9fbidxjfkgrgcnxfz9xjh2n8-python3.7-aiohttp-2.3.10.drv' failed with exit code 1; last 6 log lines:
  unpacking sources
  unpacking source archive /nix/store/5dzzs2c8hhrmychljldmjrkgcf3hilgd-aiohttp-2.3.10.tar.gz
  source root is aiohttp-2.3.10
  setting SOURCE_DATE_EPOCH to timestamp 1517564845 of file aiohttp-2.3.10/setup.cfg
  patching sources
  substitute(): ERROR: file 'pytest.ini' does not exist
cannot build derivation '/nix/store/z6zlh6hgj2088zvfwzcjdy03yl3j2p9m-python3.7-pytest-aiohttp-0.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1ba1k9sxgs5sy17jxgxvvvr1r7dmgpvl-python3.7-aiohttp-jinja2-0.15.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/w5kizcvjky785w5w41yifyvndhgijd7c-appdaemon-3.0.5.drv': 2 dependencies couldn't be built

I tried to fix, but.. not really sure if the package is actually in an invalid state or not, so I'm just marking it broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 4, 2019 04:26
@FRidh
Copy link
Member

FRidh commented Jul 4, 2019

We typically don't mark it broken in case a test fails. When we can't fix it we just skip it. Yes, there's a risk, but since test coverage is hardly ever 100% that risk is always present.

@jonringer jonringer mentioned this pull request Jul 4, 2019
Merged
10 tasks
@jonringer
Copy link
Contributor Author

Closing for preference of other PR

@jonringer jonringer closed this Jul 4, 2019
@jonringer jonringer deleted the mark-seekpath-broken branch July 9, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh