kakounePlugins.kak-ansi: init at 0.2.1 #64310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
requested changes
Jul 9, 2019
alyssais
reviewed
Jul 9, 2019
alyssais
reviewed
Jul 9, 2019
|
I added UNLICENSE to the kak-ansi repo, did all the mentioned things, and also renamed |
eraserhd
force-pushed
the
kak-ansi
branch
2 times, most recently
from
c3f5c77
to
c3bfc67
Compare
|
I missed a requested change way back when, but it is resolved now. |
eraserhd
changed the title
nrdxp
added a commit
to nrdxp/nixpkgs
that referenced
this pull request
Aug 28, 2019
Should be compatible with NixOS#64310 * kak-auto-pairs: for automatic closing of pairs * kak-buffers: for easier buffer management * kak-fzf: for fzf integration * kak-powerline: for a prettier modeline * kak-vertical-selection: for easy vertical selections
aristidb
pushed a commit
that referenced
this pull request
Sep 3, 2019
* kakounePlugins: Add 5 kakoune plugins Should be compatible with #64310 * kak-auto-pairs: for automatic closing of pairs * kak-buffers: for easier buffer management * kak-fzf: for fzf integration * kak-powerline: for a prettier modeline * kak-vertical-selection: for easy vertical selections * kakounePlugins: alphabetize package list * kakounePlugins.kak-fzf: add ability to choose between fzf/skim * kakounePlugins.kak-powerline: substitute full path to git binary
|
rebased to fix merge conflict. @alyssais Can you merge? |
alyssais
reviewed
Sep 6, 2019
| sha256 = "15bw3rhwmary50j850akm766ig6klflgkily60m5zvic0rsvlk2p"; | ||
| }; | ||
| buildPhase = '' | ||
| $CC -O2 -std=c99 -o kak-ansi-filter kak-ansi-filter.c |
There was a problem hiding this comment.
Still sceptical of this. Suppose guix wants to also have kak-ansi. They have to copy this? Why not just let people who want to precompile run make?
eraserhd
changed the title
|
@alyssais Should be all good now? |
alyssais
requested changes
Sep 9, 2019
|
@alyssais whitespace added, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow installing kak-ansi from nix.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Package closure size starts at 28,169,192.
Been using this locally on both NixOS and MacOS for a while.