Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mathoid: init at 0.7.2 #64311

Closed
wants to merge 1 commit into from
Closed

mathoid: init at 0.7.2 #64311

wants to merge 1 commit into from

Conversation

michaelpj
Copy link
Contributor

mathoid is a service that renders mathematical formulae on the
server-side. As such it can be used to e.g. prerender MathJax formulae
rather than relying on doing so on the client. This is very useful if
you want to include them in a non-webpage format.

Of course one does not just Add A Single Node Package. I ran generate.sh and it updated various things a little bit, but I think that should be fine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@michaelpj
mathoid: init at 0.7.2
45f5bc8 
`mathoid` is a service that renders mathematical formulae on the
server-side. As such it can be used to e.g. prerender MathJax formulae
rather than relying on doing so on the client. This is very useful if
you want to include them in a non-webpage format.
@teto
Copy link
Member

teto commented Jul 6, 2019

isn't it possible to just split into different commits the mathoid update from the rest via git add -p for instance ? would make reverting this peculiar package easier or the node update easier. You may even not want to include the rest of node updates.

@michaelpj
Copy link
Contributor Author

That would require me to know which (transitive) dependencies are the mathoid ones. I'm not sure there's any way for me to know that?

FWIW this seems to be what's happened historically when people have added new node packages.

@teto
Copy link
Member

teto commented Jul 8, 2019

another way would be to run an update first, commit and then rerun the update with your commit. One could assume no update in-between.
If node maintainers are fine without the change, then that's ok, I was just trying to increase your odds :p

@michaelpj
Copy link
Contributor Author

I'm no longer using this.

@michaelpj michaelpj closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelpj @teto