Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerdns: 4.1.9 -> 4.1.10 (CVE-2019-10162, CVE-2019-10163) #64272

Merged
merged 2 commits into from Jul 13, 2019
Merged

powerdns: 4.1.9 -> 4.1.10 (CVE-2019-10162, CVE-2019-10163) #64272

merged 2 commits into from Jul 13, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 4, 2019
@ofborg ofborg bot requested review from disassembler and Mic92 July 4, 2019 00:48
jonringer
jonringer approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64272 passes on NixOS
diff LGTM
binaries work

[3 built, 17 copied (370.3 MiB), 44.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64272
1 package were build:
powerdns

./results/powerdns/bin/pdns_control --help
syntax:

  --chroot=...
...

@Mic92
Copy link
Member

Mic92 commented Jul 4, 2019

@GrahamcOfBorg test powerdns

vcunat
vcunat approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Upstream changes are minimal: https://doc.powerdns.com/authoritative/changelog/4.1.html#change-4.1.10

pull bot pushed a commit to milibopp/nixpkgs that referenced this pull request Jul 13, 2019
@vcunat
Merge NixOS#64272: powerdns: 4.1.9 -> 4.1.10 (DoS security)
64cb53d 
CVE-2019-10162, CVE-2019-10163
@vcunat vcunat merged commit b1552d9 into NixOS:master Jul 13, 2019
vcunat added a commit that referenced this pull request Jul 13, 2019
@vcunat
Merge #64272: powerdns: 4.1.9 -> 4.1.10 (DoS security)
fb30dec 
CVE-2019-10162, CVE-2019-10163

(cherry picked from commit 64cb53d)
@vcunat
Copy link
Member

vcunat commented Jul 13, 2019

19.03: fb30dec

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jonringer jonringer jonringer approved these changes

@disassembler disassembler Awaiting requested review from disassembler

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
1.severity: security 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alyssais @Mic92 @vcunat @jonringer @TredwellGit