Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pari: 2.11.1 -> 2.11.2 #64271

Merged
merged 1 commit into from Aug 31, 2019
Merged

pari: 2.11.1 -> 2.11.2 #64271

merged 1 commit into from Aug 31, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.

I don’t actually use this software, just happened to notice it was out of date. Would appreciate a look over by somebody familiar with it. Upstream refers to this as a bug fix release, so I plan to backport to stable unless there’s some reason I shouldn’t.

@alyssais alyssais added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 4, 2019
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64271 fails, breaks sage and sageWithDoc

Fail log
builder for '/nix/store/g69h2ad1xxwmw10i0bigq9fiqgf1wzmw-sage-tests-8.8.drv' failed with exit code 1; last 10 log lines:
  sage -t --long /nix/store/4wwbhg1871gkbwljpjfrq615dgr6czkv-python-2.7.16-env/lib/python2.7/site-packages/sagenb/notebook/worksheet.py
      [579 tests, 5.94 s]
  sage -t --long /nix/store/nqxxyb9m2fnszly1y1rb1xfja0g9n4jy-sage-src-8.8/src/sage/tests/cmdline.py
      [238 tests, 38.66 s]
  ----------------------------------------------------------------------
  sage -t --long /nix/store/nqxxyb9m2fnszly1y1rb1xfja0g9n4jy-sage-src-8.8/src/sage/matrix/matrix_space.py  # 1 doctest failed
  ----------------------------------------------------------------------
  Total time for all tests: 3141.2 seconds
      cpu time: 7618.1 seconds
      cumulative wall time: 12044.8 seconds
cannot build derivation '/nix/store/9555s7rwkgm48pg72w9wv48l746kjh4b-sage-8.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sv7qicvcixqllj813bz87mwfyylmwnxx-sage-8.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/63k5jgvkgnpidxggp9s5h4fqxhdwd22j-env.drv': 2 dependencies couldn't be built
[107 built (1 failed), 578 copied (2422.3 MiB), 671.6 MiB DL]
error: build of '/nix/store/63k5jgvkgnpidxggp9s5h4fqxhdwd22j-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64271
2 package failed to build:
sage sageWithDoc

14 package were build:
eclib giac giac-with-xcas gp2c lcalc pari python27Packages.cypari2 python27Packages.cysignals python27Packages.fpylll python27Packages.pplpy python37Packages.cypari2 python37Packages.cysignals python37Packages.fpylll python37Packages.pplpy

@timokau
Copy link
Member

timokau commented Jul 4, 2019

Thank you for taking the time to run those tests! I can't reproduce the failure, at least not when running that one test in isolation. Can you?

nix-build -E 'with (import ./. {}); sage.tests.override { files = [ "src/sage/matrix/matrix_space.py" ];}'

Also the whole log for /nix/store/g69h2ad1xxwmw10i0bigq9fiqgf1wzmw-sage-tests-8.8.drv would be useful.

@alyssais
Copy link
Member Author

I can’t reproduce either, so I’m assuming it was either transient or has been fixed.

@alyssais alyssais merged commit 1da1a7a into NixOS:master Aug 31, 2019
@alyssais
Copy link
Member Author

alyssais commented Aug 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants