Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/netdata: update service config #64329

Merged
merged 2 commits into from Jul 6, 2019
Merged

nixos/netdata: update service config #64329

merged 2 commits into from Jul 6, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 5, 2019 •
edited

Motivation for this change

Add reload options and enable start with pid file.
Signals netdata handles:

  • HUP Close and reopen log files.
  • USR1 Save internal DB to disk.
  • USR2 Reload health configuration.

Update performance - https://docs.netdata.cloud/docs/high-performance-netdata/

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto
teto approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested neither used netdata but changes look like an inprovement

@teto
Copy link
Member

teto commented Jul 6, 2019

would be nice if you could update the commits to reflect the changes: "update service config" is rather vague while the issue description is much better.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 6, 2019 •
edited

@teto thanks, update commit message.

@Mic92 Mic92 merged commit e111f23 into NixOS:master Jul 6, 2019
@Izorkin Izorkin deleted the netdata branch July 6, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @teto @Mic92