New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-generate: init at 0.3.0 #64245
Conversation
e68a706
to
5652ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ nix-review pr 64245
passes on NixOS
diff LGTM
binary works
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64245
1 package were build:
cargo-generate
./results/cargo-generate/bin/cargo-generate --help
cargo-generate 0.3.0
Ashley Williams <ashley666ashley@gmail.com>
Generate a new Cargo project from a given template
...
@GrahamcOfBorg build cargo-generate |
@xrelkd I think there is probably an issue with macos build still. I've borrowed my mac to the girlfriend who has her on repair (keyboard :/) but I tried to build this quickly on that machine and ran into some issues with linking C libs. I will have that machine back soon enough so I think it makes sense to wait with merge for now after I make sure it works on darwin as well. |
@xrelkd build on darwin is now fixed. Do you want me to rebase this against current master? |
45eba4e
to
71bb45f
Compare
45eba4e
to
925faca
Compare
Not sure. |
# Tests depend on a valid git configuration. | ||
# Rather than doing some crazy hack and adding additional dependencies | ||
# we simply avoid them completely. | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try
preCheck = ''
export GIT_COMMITTER_NAME=nixbld
export EMAIL=nixbld@localhost
export GIT_COMMITTER_DATE=$SOURCE_DATE_EPOCH
'';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the whole test suit will do quite some side-effects. Just adding this produces following error during build
---- basics::it_substitutes_projectname_in_cargo_toml stdout ----
thread 'basics::it_substitutes_projectname_in_cargo_toml' panicked at 'Unexpected failure.
code-128
stderr=```fatal: invalid date format: 1
command="git" "commit" "--message" "initial commit"
code=128
stdout=``````
stderr=```fatal: invalid date format: 1
', /build/cargo-generate-0.3.0-vendor/assert_cmd/src/assert.rs:140:13
I'm not sure how to fix this but I can try to figure it out. Anyway I would expect there will be more issues along the way and am not sure if it's worth trying to fix all of those.
@turboMaCk sorry for the delay, LGTM. before I merge it, would you mind squashing the commits? |
e945128
to
b2d541b
Compare
e945128
to
94335e1
Compare
@marsam don't worry it was wip most of the time (waiting for me to find a time to fix darwin). Now it's squashed. there is still |
94335e1
to
02d79ce
Compare
IMHO I think it's always beneficial to enable the tests; but in some cases, like this one, is a bit complicated to setup, and it shouldn't hold its merge. |
Motivation for this change
Usefull missing tool
Things done
Expression added
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)