Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solargraph: 0.32.1 -> 0.34.2 #64246

Merged
merged 1 commit into from Jul 3, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Jul 3, 2019

Motivation for this change
Things done
rm Gemfile.lock gemset.nix
bundle install
bundix
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64246 passes on NixOS
diff LGTM (although, I don't know much about packaing ruby packages)
binary works

[14 built, 13 copied (26.2 MiB), 13.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64246
1 package were build:
solargraph
./results/solargraph/bin/solargraph --help
Commands:
  solargraph --version, -v            # Print the version
  solargraph available-cores          # List available documentation versions
...

@zimbatm zimbatm merged commit a53358e into NixOS:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants