Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-contacts: fix build #64297

Merged
merged 1 commit into from Jul 4, 2019
Merged

gnome3.gnome-contacts: fix build #64297

merged 1 commit into from Jul 4, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 4, 2019 •
edited

ibhandy 0.0.10 added a HeaderBar type, which means this
clashes with that of Gtk. Apply upstream patch that fixes this.

Instigated by

Motivation for this change

GNOME3 test failure https://hydra.nixos.org/build/95718709

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
gnome3.gnome-contacts: fix build
1a49479 
ibhandy 0.0.10 added a HeaderBar type, which means this
clashes with that of Gtk. Apply upstream patch that fixes this.

Instigated by
* 48044cd
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jul 4, 2019
@ofborg ofborg bot requested review from hedning and jtojnar July 4, 2019 12:20
@worldofpeace worldofpeace merged commit 818ed0b into NixOS:master Jul 4, 2019
@worldofpeace worldofpeace deleted the gnome-contacts/fix-build branch July 4, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace