Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.soco: 0.16 -> 0.17 #64348

Merged
merged 1 commit into from Jul 6, 2019
Merged

pythonPackages.soco: 0.16 -> 0.17 #64348

merged 1 commit into from Jul 6, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 5, 2019 •
edited

Now works with latest pytestcov

This transitively fixes beets (fixes #64339) which depends on soco, which now doesn't depend on
pytest_3 anymore, which depends on pytestcov_3, which is broken.

An upstream PR for the patch here has been submitted: SoCo/SoCo#670

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
pythonPackages.soco: 0.16 -> 0.17
622e553 
Now works with latest pytestcov

This transitively fixes beets which depends on soco, which now doesn't depend on
pytest_3 anymore, which depends on pytestcov_3, which is broken.
@infinisil infinisil requested a review from FRidh as a code owner July 5, 2019 16:34
@FRidh
Copy link
Member

FRidh commented Jul 5, 2019

@GrahamcOfBorg build beets

@FRidh FRidh merged commit c1f08d7 into NixOS:master Jul 6, 2019
@infinisil infinisil deleted the update/soco branch July 6, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beets does not build due to pytest build failure
2 participants
@infinisil @FRidh