HTML: WPT for tabIndex #17657
Merged
HTML: WPT for tabIndex #17657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
annevk
approved these changes
Jul 8, 2019
...nteraction/focus/sequential-focus-navigation-and-the-tabindex-attribute/tabindex-getter.html
Outdated
Show resolved
Hide resolved
...nteraction/focus/sequential-focus-navigation-and-the-tabindex-attribute/tabindex-getter.html
Outdated
Show resolved
Hide resolved
...nteraction/focus/sequential-focus-navigation-and-the-tabindex-attribute/tabindex-getter.html
Outdated
Show resolved
Hide resolved
...nteraction/focus/sequential-focus-navigation-and-the-tabindex-attribute/tabindex-getter.html
Outdated
Show resolved
Hide resolved
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 9, 2019
This updates the tabIndex getter's default value to be 0 for a specific list of element types, instead of the spec's previous "elements that are focusable". This matches reality better; apart from minor edge cases all three browser engines match this spec in observable behavior. Closes #1786. Closes #4464. See the focus meta-bug in #4607 for related discussions, including on adding an API that actually reflects whether an element is focusable (like the tabIndex getter was kind-of supposed to do). Tests: web-platform-tests/wpt#17657
3 tasks
|
Let's merge this test. |
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
* HTML: WPT for tabIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#4754 for the spec change.
This is consistent with behaviors in Chrome, Safari, Firefox - see table in whatwg/html#4464 (comment) Chrome is failing for the case with shadow host with delegatesFocus=true)