Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdesktop: 1.8.3 -> 1.8.6 (security release) #64265

Merged
merged 1 commit into from Jul 3, 2019
Merged

rdesktop: 1.8.3 -> 1.8.6 (security release) #64265

merged 1 commit into from Jul 3, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 3, 2019

Motivation for this change

Security release, fixing issue with as-yet-unassigned CVE. Debian are using DSA-4473-1/DLA-1837-1.

https://groups.google.com/forum/#!topic/rdesktop-announce/czgpKDfm2D0

Also switching to github source because they don't seem to be keeping their sourceforge tarballs up to date. This also requires adding a preConfigure step and autoconf/automake build deps.

I think the best thing is to similarly bump 19.03 as there's so little clarity from upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64265 passes on NixOS
diff LGTM :)
binary works

[3 built, 1 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64265
1 package were build:
rdesktop

./results/rdesktop/bin/rdesktop -help
rdesktop: A Remote Desktop Protocol client.
Version 1.8.6. Copyright (C) 1999-2011 Matthew Chapman et al.
...

@alyssais
Copy link
Member

alyssais commented Jul 3, 2019

This also requires adding a preConfigure step and autoconf/automake build deps.

You should be able to use autoreconfHook instead.

@alyssais alyssais added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 3, 2019
@risicle
Copy link
Contributor Author

risicle commented Jul 3, 2019

You should be able to use autoreconfHook instead.

Ah didn't know about that 👍

@risicle
rdesktop: 1.8.3 -> 1.8.6
44b4505 
security release, fixing issue with as-yet-unassigned CVE. debian are using
DSA-4473-1/DLA-1837-1.

switching to github source because they don't seem to be keeping their
sourceforge tarballs up to date
@grahamc
Copy link
Member

grahamc commented Jul 3, 2019

@GrahamcOfBorg build rdesktop

@adisbladis adisbladis merged commit 6bae45d into NixOS:master Jul 3, 2019
@alyssais
Copy link
Member

alyssais commented Jul 3, 2019 via email

@risicle
Copy link
Contributor Author

risicle commented Jul 3, 2019

That was fast 👍

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@risicle @alyssais @grahamc @jonringer @adisbladis @TredwellGit