Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero: 0.14.0 -> 0.14.1 #64263

Merged
merged 6 commits into from Jul 3, 2019
Merged

monero: 0.14.0 -> 0.14.1 #64263

merged 6 commits into from Jul 3, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 3, 2019

Motivation for this change

Continuing PR #63700.
The hash for monero has changed again plus the build was failing and a patch needed to be updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using (none)
  • Tested execution
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review pr 64263 passes on NixOS
diff LGTM
binaries and gui work

@fpletz fpletz merged commit 74049df into NixOS:master Jul 3, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 4, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants