Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop nodejs-8_x #64336

Merged
merged 2 commits into from Aug 2, 2019
Merged

Drop nodejs-8_x #64336

merged 2 commits into from Aug 2, 2019

Conversation

adisbladis
Copy link
Member

Motivation for this change

Will go EOL during 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ma27 July 5, 2019 11:39
@Ma27
Copy link
Member

Ma27 commented Jul 9, 2019

First of all, the overall change looks fine 👍
cc nodejs maintainers @gilligan @cko @cillianderoiste

Regarding codimd (which is probably the reason why I got pinged by ofborg): I just tested it locally and when running the test, the service fails with the following error:

codimdPostgres# [  583.597186] codimd[2293]: 2019-07-09T22:49:45.136Z - error: uncaughtException: Cannot find module 'diff-match-patch' date=Tue Jul 09 2019 22:49:45 GMT+0000 (Coordinated Universal Time), pid=2294, uid=1000, gid=499, cwd=/var/lib/codimd, execPath=/nix/store/59506cd55zicdmn8rgnw1b728phfh6r1-nodejs-10.16.0/bin/node, version=v10.16.0, argv=[/nix/store/59506cd55zicdmn8rgnw1b728phfh6r1-nodejs-10.16.0/bin/node, /nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/app.js], rss=92327936, heapTotal=72056832, heapUsed=40506992, external=219530, loadavg=[0.95361328125, 0.95703125, 0.55859375], uptime=583, trace=[column=15, file=internal/modules/cjs/loader.js, function=Module._resolveFilename, line=636, method=_resolveFilename, native=false, column=25, file=internal/modules/cjs/loader.js, function=Module._load, line=562, method=_load, native=false, column=17, file=internal/modules/cjs/loader.js, function=Module.require, line=690, method=require, native=false, column=18, file=internal/modules/cjs/helpers.js, function=require, line=25, method=null, native=false, column=22, file=/nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/note.js, function=null, line=14, method=null, native=false, column=30, file=internal/modules/cjs/loader.js, function=Module._compile, line=776, method=_compile, native=false, column=10, file=internal/modules/cjs/loader.js, function=Module._extensions..js, line=787, method=.js, native=false, column=32, file=internal/modules/cjs/loader.js, function=Module.load, line=653, method=load, native=false, column=12, file=internal/modules/cjs/loader.js, function=tryModuleLoad, line=593, method=null, native=false, column=3, file=internal/modules/cjs/loader.js, function=Module._load, line=585, method=_load, native=false, column=17, file=internal/modules/cjs/loader.js, function=Module.require, line=690, method=require, native=false, column=18, file=internal/modules/cjs/helpers.js, function=require, line=25, method=null, native=false, column=61, file=/nix/store/qcvlqm3xlyps3jkwzqs6myvky83hc5bn-node_sequelize-3.34.0/lib/node_modules/sequelize/lib/sequelize.js, function=Sequelize.import, line=686, method=import, native=false, column=35, file=/nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/index.js, function=null, line=45, method=null, native=false, column=null, file=null, function=Array.forEach, line=null, method=forEach, native=false, column=6, file=/nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/index.js, function=null, line=44, method=null, native=false], stack=[Error: Cannot find module 'diff-match-patch',     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15),     at Function.Module._load (internal/modules/cjs/loader.js:562:25),     at Module.require (internal/modules/cjs/loader.js:690:17),     at require (internal/modules/cjs/helpers.js:25:18),     at Object.<anonymous> (/nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/note.js:14:22),     at Module._compile (internal/modules/cjs/loader.js:776:30),     at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10),     at Module.load (internal/modules/cjs/loader.js:653:32),     at tryModuleLoad (internal/modules/cjs/loader.js:593:12),     at Function.Module._load (internal/modules/cjs/loader.js:585:3),     at Module.require (internal/modules/cjs/loader.js:690:17),     at require (internal/modules/cjs/helpers.js:25:18),     at Sequelize.import (/nix/store/qcvlqm3xlyps3jkwzqs6myvky83hc5bn-node_sequelize-3.34.0/lib/node_modules/sequelize/lib/sequelize.js:686:61),     at /nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/index.js:45:35,     at Array.forEach (<anonymous>),     at Object.<anonymous> (/nix/store/iif2f1bgmc6cvbnk2gbi0xdk320r3acv-codimd-1.2.0/lib/models/index.js:44:6)]

However I don't think that codimd is a blocker for this, also @WilliButz made some awesome progress in repackaging this with yarn2nix in #60429. As there's now a codimd/server 1.4.0 it should be ready soon anway :)

@globin globin merged commit 841e20e into NixOS:master Aug 2, 2019
@lo1tuma lo1tuma mentioned this pull request Aug 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @Ma27 @globin