Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotools: 2019-06-03 -> 2019-07-06 #64335

Merged
merged 2 commits into from Jul 7, 2019
Merged

gotools: 2019-06-03 -> 2019-07-06 #64335

merged 2 commits into from Jul 7, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Since golang/tools@d4e310b gotools repo fails to build under Nix. I suppose that's due to multiple go.mod/go.sum files present in the repository.
Fixed that by simply removing the added gopls module. Note, that cmd/gopls is still there with exactly the same content, hence working gopls binary ends up in the build output.
cc @kalbasit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build gotools

@ofborg ofborg bot requested a review from kalbasit July 5, 2019 11:36
@kalbasit
Copy link
Member

kalbasit commented Jul 5, 2019

@GrahamcOfBorg build gotools

kalbasit
kalbasit requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and it builds locally just fine. I do find gopls in the binary so that's good as well 👍

pkgs/development/tools/gotools/default.nix Show resolved Hide resolved
@rvolosatovs rvolosatovs changed the title gotools: 2019-06-03 -> 2019-07-03 gotools: 2019-06-03 -> 2019-07-06 Jul 7, 2019
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build gotools

@rvolosatovs
Copy link
Member Author

@kalbasit updated to 2019-07-06 and added the reasoning for removal of gopls module

@ofborg ofborg bot requested a review from kalbasit July 7, 2019 16:52
@kalbasit
Copy link
Member

kalbasit commented Jul 7, 2019

@GrahamcOfBorg build gotools

@kalbasit kalbasit merged commit 1aa0f1f into NixOS:master Jul 7, 2019
@rvolosatovs rvolosatovs deleted the update/gotools branch July 7, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvolosatovs @kalbasit