Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7059cb49314d
Choose a base ref
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b471e33d7f79
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 3, 2019

  1. build.res: detect physical conflicts earlier.

    This is useful for two reasons:
      1. nMigen can provide better error messages than the platform and
         do it earlier in the build pipeline.
      2. Many platforms handle diffpairs by only constraining the P pin;
         the N pin is completely ignored. If this is undetected,
         downstream users (human or software) can rely on this
         information assuming it is correct and introduce more errors.
         (Of course, this will not catch every mistake, but the most
         common is a copy-paste issue, and that will handle it.)
    
    Fixes #124.
    whitequark committed Jul 3, 2019
    Copy the full SHA
    b471e33 View commit details
Loading