Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lkl: 2018-08-22 -> 2019-06-20 #64323

Merged
merged 1 commit into from Jul 5, 2019
Merged

lkl: 2018-08-22 -> 2019-06-20 #64323

merged 1 commit into from Jul 5, 2019

Conversation

lopsided98
Copy link
Contributor

Fixes the build on 32-bit ARM, which enables the generation of SD card images
on these platforms.

This fixes #51798 (the original issue was different, but I believe it was left open because the SD image failed to build).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes the build on 32-bit ARM, which enables the generation of SD card images
on these platforms.
@teto
Copy link
Member

teto commented Jul 5, 2019

@GrahamcOfBorg build lkl

@teto
Copy link
Member

teto commented Jul 5, 2019

wanna add yourself to maintainers ? it's not your first lkl contribution :)

@teto teto merged commit 721b391 into NixOS:master Jul 5, 2019
@lopsided98 lopsided98 deleted the lkl-arm branch July 5, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

armv7l images are unable to run nixos-rebuild, nix, etc.
2 participants