Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xenomapper: init 1.0.2 #64322

Merged
merged 1 commit into from Sep 5, 2019
Merged

xenomapper: init 1.0.2 #64322

merged 1 commit into from Sep 5, 2019

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Jul 5, 2019

Motivation for this change

xenomapper: init 1.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbedo jbedo requested a review from FRidh as a code owner July 5, 2019 03:39
@mmahut
Copy link
Member

mmahut commented Jul 5, 2019

@GrahamcOfBorg build

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@jbedo do you mind rebaseing?

@jbedo
Copy link
Contributor Author

jbedo commented Aug 20, 2019

Done!

@aanderse
Copy link
Member

aanderse commented Aug 31, 2019 •
edited

@GrahamcOfBorg build python2Packages.xenomapper python3Packages.xenomapper

@aanderse
Copy link
Member

@jbedo looks like some build errors. Please address.

@jbedo
Copy link
Contributor Author

jbedo commented Sep 2, 2019

@aanderse the missing dependency has been added

@aanderse
Copy link
Member

aanderse commented Sep 5, 2019

@jbedo it appears python2Packages.xenomapper is still failing. Does this package support python2?

@jbedo
Copy link
Contributor Author

jbedo commented Sep 5, 2019

@aanderse I've verified xenomapper is supported for python 3 only. Is there a way to have it available only under python3Packages?

@aanderse
Copy link
Member

aanderse commented Sep 5, 2019

#62754 (comment)

😄

@jbedo
Copy link
Contributor Author

jbedo commented Sep 5, 2019

Wonderful, thanks!

@aanderse
Copy link
Member

aanderse commented Sep 5, 2019

@GrahamcOfBorg build python3Packages.xenomapper

aanderse
aanderse approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse merged commit 11de7aa into NixOS:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@aanderse aanderse aanderse approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedo @mmahut @aanderse