Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix: installing-pxe.xml now has a bullet list #64254

Closed
wants to merge 1 commit into from

Conversation

epitron
Copy link

@epitron epitron commented Jul 3, 2019

A bullet list wasn't in bullet form. Fixed!

A bullet list wasn't in bullet form. Fixed!
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 14, 2019

Thanks for the contribution @epitron and welcome around here since it seems to be a first PR. :)

We have a manual section describing how to build the manual to check changes.
I'm getting errors during make, first one is

./installation/installing-pxe.xml: Not feasibly valid:
Line 25:
    22   <para>
    23    This will create a <literal>result</literal> directory containing: 
    24     
    25    <listitem>
    26     <para>
    27       <literal>bzImage</literal> – the Linux kernel 
    28     </para>
     error: element "listitem" not allowed here;

(error is on line 25)

It seems you are not opening the orderedlist ?


Side note: use the provided template when opening a PR and check what you can.
Even for a doc-only contrib, it tells us what you tested. It also refers you to CONTRIBUTING.md :)

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh XML syntax errors . . . looking forward to RFC 72!

@Mindavi
Copy link
Contributor

Mindavi commented Apr 28, 2022

Hopefully this has been improved by now. Make a new PR based on all changes in the last years if you're still interested in fixing this. Since there wasn't any response from the original author, it doesn't make sense to me to keep this open any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants