Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.django: fix CVE-2019-12781 #64270

Merged
merged 4 commits into from Jul 4, 2019
Merged

python3Packages.django: fix CVE-2019-12781 #64270

merged 4 commits into from Jul 4, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jul 4, 2019 •
edited

I note we’re also still packaging django_1_8, which is unsupported upstream. Would be good to kill that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 4, 2019
@alyssais alyssais requested a review from FRidh as a code owner July 4, 2019 00:02
@alyssais
python3Packages.django_1_8: add more known vulns
6bbeeb6 
I'm just assuming that these affect 1.8, since they affect every later
version.
@alyssais
Copy link
Member Author

alyssais commented Jul 4, 2019 •
edited

Ah, there’s an issue for 1.8. #52679

And a PR: #52799

@ofborg ofborg bot requested a review from lsix July 4, 2019 00:16
@alyssais
Copy link
Member Author

alyssais commented Jul 4, 2019

@GrahamcOfBorg build python3Packages.django python3Packages.django_2_1 python3Packages.django_2_2

jonringer
jonringer approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64270 fails on 2 packages, but those 2 are broken on master
diff LGTM

[113 built (2 failed), 353 copied (761.5 MiB), 148.1 MiB DL]
error: build of '/nix/store/agi3yx3s86dnv95j659z4dhsm0jm0f95-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64270
2 package failed to build:
python27Packages.django_evolution python27Packages.suseapi

109 package were build:
...

@lsix
Copy link
Member

lsix commented Jul 4, 2019

Ok, I have tested it, good for me.

I’ll backport it to release-19.03.

@lsix lsix merged commit 49a3e77 into NixOS:master Jul 4, 2019
@lsix
Copy link
Member

lsix commented Jul 4, 2019

Backported in release-19.03: 5c0abc5 c2f9536 1ab0dd3 2b6b923

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @lsix @jonringer @TredwellGit