Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The nix build and makefile experience for the nixpkgs docs was not very nice, and extending it further was getting a bit silly.
This change replaces a bunch of annoying environment variables in the Makefile with a single
nix-build
and symlink. This change makes it much easier to experiment with the xsltproc parameters, as they're no longer in the environment.This change also makes some more advanced experimentation possible via docbook customisation layers http://www.sagehill.net/docbookxsl/CustomMethods.html#CustomizationLayer
Note: each individual commit is self contained and easy to read.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)