Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zathura-pdf-poppler: fix source url #64338

Merged
merged 1 commit into from Jul 12, 2019
Merged

zathura-pdf-poppler: fix source url #64338

merged 1 commit into from Jul 12, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Current zathura-pdf-poppler URL constantly times out - changed it to use their Gitlab directly.
Not sure why hash changed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the latency for the regular site is pretty bad and git is quite good.
It still builds fine - haven't tested it though.

The hash changed because it's a different compression format xz -> gz.

@dywedir dywedir merged commit ec381b5 into NixOS:master Jul 12, 2019
@rvolosatovs rvolosatovs deleted the fix/zathura-pdf-poppler branch July 12, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @JohnAZoidberg @dywedir