Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 2.0.3 -> 3.0.0 #64342

Merged
merged 2 commits into from Jul 6, 2019
Merged

kustomize: 2.0.3 -> 3.0.0 #64342

merged 2 commits into from Jul 6, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 5, 2019 •
edited

Motivation for this change

Bump to latest release : release notes.
This also migrate the package to use buildGoModule as it is now using go modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vdemeester
kustomize: 2.0.3 -> 3.0.0
ca5581e 
This also migrate the package to use `buildGoModule` as it is now
using go modules.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@GrahamcOfBorg build kustomize

@ofborg ofborg bot requested review from kalbasit and periklis July 5, 2019 12:26
periklis
periklis approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalbasit
Copy link
Member

kalbasit commented Jul 5, 2019

@GrahamcOfBorg build kustomize

@vdemeester @kalbasit
Apply suggestions from code review
07868b8 
Co-Authored-By: Wael Nasreddine <wael.nasreddine@gmail.com>
@kalbasit
Copy link
Member

kalbasit commented Jul 5, 2019

@GrahamcOfBorg build kustomize

@ofborg ofborg bot requested review from kalbasit and periklis July 5, 2019 16:56
kalbasit
kalbasit approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's usually up to the author to rebase the commits. I'll squash merge this time.

@kalbasit kalbasit merged commit d567c48 into NixOS:master Jul 6, 2019
@vdemeester vdemeester deleted the update-kustomize branch July 6, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @kalbasit @periklis