skaffold: 0.30.0 -> 0.34.1 #64341
Closed
skaffold: 0.30.0 -> 0.34.1 #64341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build skaffold |
teto
reviewed
Jul 6, 2019
| version = "0.30.0"; | ||
| # rev is the 0.30.0 commit, mainly for skaffold version command output | ||
| version = "0.33.0"; | ||
| # rev is the 0.33.0 commit, mainly for skaffold version command output | ||
| rev = "fe31429012110e6fd70f97971288bd266ba95bed"; |
There was a problem hiding this comment.
is it normal that the rev wasn't changed even though the comment points at another version ?
teto
reviewed
Jul 6, 2019
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| buildGoPackage rec { | |||
| name = "skaffold-${version}"; | |||
There was a problem hiding this comment.
you could change it to pname = "skaffold";
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
update-skaffold
branch
from
5956f02
to
9941cc3
Compare
|
@GrahamcOfBorg build skaffold |
|
This pull request has been mentioned on Nix community. There might be relevant details there: |
|
obsoleted by #66691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bump to latest release.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)