Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/iperf: add openFirewall setting #64280

Merged
merged 1 commit into from Jul 4, 2019
Merged

nixos/iperf: add openFirewall setting #64280

merged 1 commit into from Jul 4, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jul 4, 2019 •
edited

Opens the specified tcp port.

Motivation for this change

I find the setting useful whenever I deploy an iperf server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
nixos/iperf: add openFirewall setting
fd4096d 
Opens the specified tcp port.
@teto
Copy link
Member Author

teto commented Jul 4, 2019

CC @dasJ . Btw would you want to be added as a maintainer of the module ?

aanderse
aanderse approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dasJ
Copy link
Member

dasJ commented Jul 4, 2019

@teto Thanks! But one thing to consider is the possibility of UDP tests. Would you mind adding a second option?

@teto
Copy link
Member Author

teto commented Jul 4, 2019 •
edited

It would mean adding a parameter to know if udp is used (else we might open a udp port for nothing). I would rather leave the PR up to someone who actually uses the UDP test.
What about assigning maintainership to you :p ?

@dasJ
Copy link
Member

dasJ commented Jul 4, 2019 •
edited

Alright, I agree.
Yeah, just do that :) I also have some code here to sandbox the daemon and I will publish that once I wrote a test for it
Note that my username is das_j and not dasJ in the maintainers file.

@teto teto merged commit 2ebeba4 into NixOS:master Jul 4, 2019
@teto teto deleted the iperf_openFirewall branch July 4, 2019 14:59
@teto
Copy link
Member Author

teto commented Jul 4, 2019

I was going to add you but it's more elegant if you do it yourself (plus I got lazy :p). Ping me when you open your PR and I'll review it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @dasJ @aanderse