Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cue: init at 0.0.3 #64367

Merged
merged 1 commit into from Jul 6, 2019
Merged

cue: init at 0.0.3 #64367

merged 1 commit into from Jul 6, 2019

Conversation

solson
Copy link
Member

@solson solson commented Jul 6, 2019

Motivation for this change

Packaging a new development tool, CUE. Despite the 0.0.3 version number, it seems pretty usable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is my first time packaging a Go program, so let me know if I'm doing anything poorly.

@ofborg ofborg bot requested a review from kalbasit July 6, 2019 03:58
@kalbasit
Copy link
Member

kalbasit commented Jul 6, 2019

@GrahamcOfBorg build cue

@kalbasit kalbasit merged commit 0b492c0 into NixOS:master Jul 6, 2019
@solson solson deleted the cue-init branch July 6, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solson @kalbasit