Allow NetworkManager and wireless together #64364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto
reviewed
Jul 7, 2019
| @@ -173,13 +173,24 @@ in { | |||
| ''; | |||
| }; | |||
|
|
|||
| withSupplicant = mkOption { | |||
| internal = true; | |||
There was a problem hiding this comment.
Not sure about the internal here. Also we could use a more generic option like "ignoreWireless"/ "delegateWireless" without naming supplicant as there might be other options in the future.
There was a problem hiding this comment.
I'm not exactly sure about the semantics of internal.
Actually I think I want it to be just a variable.
Is internal like a config option that the user cannot set themself, just the module?
Yeah okay, not calling it supplicant makes sense.
There was a problem hiding this comment.
I switched to a variable with the name delegateWireless.
JohnAZoidberg
force-pushed
the
nm-wireless
branch
from
8f34186
to
699bb98
Compare
JohnAZoidberg
force-pushed
the
nm-wireless
branch
2 times, most recently
from
8afa5f5
to
9ab92c1
Compare
JohnAZoidberg
force-pushed
the
nm-wireless
branch
from
9ab92c1
to
6790ead
Compare
When NetworkManager is configured to not manage all interfaces, it's
perfectly fine to have the rest be managed by the standard nixos
wireless scripts.
I use
networking.networkmanager.unmanaged = [
"*" "except:type:wwan" "except:type:gsm"
];
to control everything using networking.wireless except for the mobile
LTE modem which only works with NetworkManager.
JohnAZoidberg
force-pushed
the
nm-wireless
branch
from
6790ead
to
b4044a3
Compare
|
Rebased on top of master. |
jtojnar
added a commit
to jtojnar/nixpkgs
that referenced
this pull request
Nov 6, 2019
Incorrect merging of modules resulted in dhcpcd being enabled causing flaky network connection. NixOS#64364 Fixing it uncovered an infinite recursion from the same commit, previously masked by the incorrect merge. We can just drop the `mkDefault` for `networking.wireless.enable` as it is already `false` by default. Closes: NixOS#72416
jtojnar
added a commit
to jtojnar/nixpkgs
that referenced
this pull request
Nov 6, 2019
Incorrect merging of modules resulted in dhcpcd being enabled causing flaky network connection. NixOS#64364 Fixing it uncovered an infinite recursion from the same commit, previously masked by the incorrect merge. While this is not a problem in 19.09, we can still drop the `mkDefault` for `networking.wireless.enable` as it is already `false` by default. Closes: NixOS#72416 (cherry picked from commit 894fdfa)
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 7, 2019
Incorrect merging of modules resulted in dhcpcd being enabled causing flaky network connection. NixOS#64364 Fixing it uncovered an infinite recursion from the same commit, previously masked by the incorrect merge. We can just drop the `mkDefault` for `networking.wireless.enable` as it is already `false` by default. Closes: NixOS#72416 (cherry picked from commit 894fdfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When NetworkManager is configured to not manage all interfaces, it's
perfectly fine to have the rest be managed by the standard nixos
wireless scripts.
I use something like this:
to control everything using networking.wireless except for the mobile
LTE modem which only works with NetworkManager.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)