nixos/tt-rss: remove deprecated usage of PermissionsStartOnly, specify a group to run service as, and fix local pgsql database creation #64365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y a group to run service as, and fix local pgsql database creation
|
Can maybe test tomorrow. |
|
Tested, works. |
|
@telotortium Thanks for testing! Did you test on an existing or fresh install? Which database backend did you test? |
|
Existing install, PostgresSQL
…On Tue, Jul 16, 2019 at 3:15 PM Aaron Andersen ***@***.***> wrote:
@telotortium <https://github.com/telotortium> Thanks for testing! Did you
test on an existing or fresh install? Which database backend did you test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64365?email_source=notifications&email_token=AANMVDMM55NRLUZYXCW4ESLP7ZCABA5CNFSM4H6SKXI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2CKDJQ#issuecomment-512008614>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANMVDJCNDBASRACT5FAQZTP7ZCABANCNFSM4H6SKXIQ>
.
--
Robert Irelan
rirelan@gmail.com
|
flokli
reviewed
Jul 18, 2019
|
Merging based on testing from @telotortium. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#55370
#53852
#40437 (partial fix)
#64312 (potential fix?)Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)ping @edermi @matthiasbeyer @telotortium for testing and review please.