Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hy: 0.16.0 -> 0.17.0 #64294

Merged
merged 2 commits into from Jul 4, 2019
Merged

hy: 0.16.0 -> 0.17.0 #64294

merged 2 commits into from Jul 4, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadeokondrak tadeokondrak requested a review from FRidh as a code owner July 4, 2019 10:10
@tadeokondrak tadeokondrak changed the title Hy/update/0.17.0 hy: 0.16.0 -> 0.17.0 Jul 4, 2019
jonringer
jonringer reviewed Jul 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64294 passes on NixOS
diff LGTM
binary works

[33 built, 59 copied (591.4 MiB), 323.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64294
20 package were build:
hy python27Packages.astor python27Packages.baselines python27Packages.dm-sonnet python27Packages.edward python27Packages.graph_nets python27Packages.tensorflow python27Packages.tensorflow-probability python27Packages.tensorflowWithCuda python27Packages.tflearn python37Packages.astor python37Packages.baselines python37Packages.dm-sonnet python37Packages.edward python37Packages.graph_nets python37Packages.rl-coach python37Packages.tensorflow python37Packages.tensorflow-probability python37Packages.tensorflowWithCuda python37Packages.tflearn

$ ./results/hy/bin/hy
hy 0.17.0 using CPython(default) 2.7.16 on Linux
=>
...

nix path-info -Sh ./results/hy
/nix/store/03l9cfpyv372r7bbam2drf6mjvr80gfh-hy-0.17.0    103.6M

@markuskowa
Copy link
Member

@GrahamcOfBorg build hy

@markuskowa
Copy link
Member

Changelog: https://github.com/hylang/hy/releases

@markuskowa markuskowa merged commit 9390903 into NixOS:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadeokondrak @markuskowa @jonringer