Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libyaml: 0.2.1 -> 0.2.2 #64293

Merged
merged 1 commit into from Jul 5, 2019
Merged

libyaml: 0.2.1 -> 0.2.2 #64293

merged 1 commit into from Jul 5, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadeokondrak tadeokondrak changed the base branch from master to staging July 4, 2019 10:14
@ofborg ofborg bot added 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: stdenv Standard environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 8.has: documentation 8.has: module (update) and removed 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: printing 6.topic: python labels Jul 4, 2019
@FRidh FRidh merged commit 3f19225 into NixOS:staging Jul 5, 2019
@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

python*Packages.pyyaml is broken now (tests): https://hydra.nixos.org/build/96093071

@FRidh
Copy link
Member

FRidh commented Jul 15, 2019

Reported upstream yaml/pyyaml#320.

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

This yaml-0.2.2.tar.gz seems very suspicious (see the last link).

@FRidh
Copy link
Member

FRidh commented Jul 15, 2019

Should fetch from https://github.com/yaml/libyaml

@vcunat
Copy link
Member

vcunat commented Jul 15, 2019

That would have the disadvantage of having to use autotools during the build.

In any case, it seems we have to make a libyaml rebuild (not too bad, ~3k together). I suggest to just use the "new" tarball:

-    sha256 = "1karpcfgacgppa82wm2drcfn2kb6q2wqfykf5nrhy20sci2i2a3q";
+    sha256 = "4a9100ab61047fd9bd395bcef3ce5403365cafd55c1e0d0299cde14958e47be9";

as the tarball seems OK to me and pyyaml tests also pass with it. What do you think?

@vcunat vcunat mentioned this pull request Jul 15, 2019
Merged
10 tasks
@FRidh FRidh mentioned this pull request Jul 16, 2019
Closed
@etu etu mentioned this pull request Aug 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tadeokondrak @vcunat @FRidh @ttuegel