Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflared: 2018.10.3 -> 2019.7.0 #64349

Merged
merged 1 commit into from Jul 13, 2019
Merged

cloudflared: 2018.10.3 -> 2019.7.0 #64349

merged 1 commit into from Jul 13, 2019

Conversation

ericnorris
Copy link
Contributor

@ericnorris ericnorris commented Jul 5, 2019 •
edited

Motivation for this change

Updating cloudflared to 2019.7.0. I've also switched to using the tagged release in the rev field, and included the version in the build flags. I've left the built date unspecified, wasn't sure how to do that and maintain a reproducible build.

$ ./result-bin/bin/cloudflared --version
cloudflared version 2019.7.0 (built unknown)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 5, 2019

@GrahamcOfBorg build

@ivan
Copy link
Member

ivan commented Jul 5, 2019

@GrahamcOfBorg build cloudflared

@ericnorris
Copy link
Contributor Author

@ivan @mmahut anything I could do to help this get merged?

@ericnorris
cloudflared: 2018.10.3 -> 2019.7.0
79643b8 
- switch to tagged release
- added version to build flags
@ericnorris ericnorris changed the title cloudflared: 2018.10.3 -> 2019.6.0 cloudflared: 2018.10.3 -> 2019.7.0 Jul 12, 2019
@worldofpeace
Copy link
Contributor

@ericnorris How did you generate the deps.nix file? I've tried doing this with dep2nix with a git checkout but it always fails with

error checking out branch: Unexpected error while defensively cleaning up after possible derelict nested submodule directories

@ericnorris
Copy link
Contributor Author

Hey @worldofpeace, I cloned the cloudflared repository, ran git checkout 2019.7.0, and then ran dep2nix.

@worldofpeace
Copy link
Contributor

Hey @worldofpeace, I cloned the cloudflared repository, ran git checkout 2019.7.0, and then ran dep2nix.

Indeed it's interesting that I cannot generate it. I suppose it's been done correctly so this can be merged 👍

@worldofpeace worldofpeace merged commit b53a6a9 into NixOS:master Jul 13, 2019
@ericnorris ericnorris deleted the cloudflared-2019.6.0 branch July 13, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericnorris @mmahut @ivan @worldofpeace