Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode{,ium}: 1.35.1 -> 1.36.0 #64308

Merged
merged 4 commits into from Jul 4, 2019
Merged

vscode{,ium}: 1.35.1 -> 1.36.0 #64308

merged 4 commits into from Jul 4, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I'm assuming are c69aeba 6a01e70 because of

?

@eadwu
Copy link
Member Author

eadwu commented Jul 4, 2019

Yeah, https://code.visualstudio.com/updates/v1_36#_linux-32bit-support-ends.

worldofpeace
worldofpeace approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed all binaries and verified hashes for the platforms 👍

@worldofpeace worldofpeace merged commit cc631b7 into NixOS:master Jul 4, 2019
@worldofpeace
Copy link
Contributor

I'd say backports are off the table here since it removed a platform, though it is i686-linux.

@vcunat vcunat mentioned this pull request Nov 18, 2019
Closed
@eadwu eadwu deleted the vscode/1.36.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @worldofpeace